flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "vinoyang (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (FLINK-9844) PackagedProgram does not close URLClassLoader
Date Fri, 13 Jul 2018 11:33:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

vinoyang reassigned FLINK-9844:

    Assignee: vinoyang

> PackagedProgram does not close URLClassLoader
> ---------------------------------------------
>                 Key: FLINK-9844
>                 URL: https://issues.apache.org/jira/browse/FLINK-9844
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Job-Submission
>    Affects Versions: 1.4.2, 1.5.1, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: vinoyang
>            Priority: Major
> The {{PackagedProgram}} class creates a user-code classloader to execute the programs
{{main}} method.
> This classloader is a {{URLClassLoader}} (except in the case of some tests), which contains
opened {{JarFiles}} for all accessed jars.
> The {{URLClassLoader}} class implements {{Closeable}} for the purpose of cleaning up
closeable resources, however we never actually call this method. The {{PackagedProgram}} only
works against the {{ClassLoader}} class, which doesn't implement {{Closeable}}.
> As a result, deleting a jar after submitting it with the {{JarRunHandler}} currently
fails on Windows, since the jar is still in use.
> As far as i can tell after the JobGraph has been compiled this classloader is no longer
necessary and should be closed. (This assumes that a given {{PackagedProgram}} is only used
once to create a JobGraph}}, otherwise we'd needa dedicate close method)

This message was sent by Atlassian JIRA

View raw message