flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9823) Add Kubernetes deployment files for standalone job cluster
Date Fri, 13 Jul 2018 12:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542972#comment-16542972
] 

ASF GitHub Bot commented on FLINK-9823:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6320#discussion_r202300463
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.entrypoint;
    +
    +import org.apache.flink.runtime.entrypoint.parser.CommandLineParser;
    +import org.apache.flink.util.TestLogger;
    +
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +import static org.hamcrest.Matchers.arrayContaining;
    +import static org.hamcrest.Matchers.equalTo;
    +import static org.hamcrest.Matchers.hasEntry;
    +import static org.hamcrest.Matchers.is;
    +import static org.junit.Assert.assertThat;
    +import static org.junit.Assert.fail;
    +
    +/**
    + * Tests for the {@link EntrypointClusterConfigurationParserFactory}.
    + */
    +public class EntrypointClusterConfigurationParserFactoryTest extends TestLogger {
    +
    +	@Test
    +	public void testEntrypointClusterConfigurationParsing() throws FlinkParseException {
    +		final CommandLineParser<EntrypointClusterConfiguration> commandLineParser = new
CommandLineParser<>(new EntrypointClusterConfigurationParserFactory());
    --- End diff --
    
    Could be moved to a `setUp` method.


> Add Kubernetes deployment files for standalone job cluster
> ----------------------------------------------------------
>
>                 Key: FLINK-9823
>                 URL: https://issues.apache.org/jira/browse/FLINK-9823
>             Project: Flink
>          Issue Type: New Feature
>          Components: Kubernetes
>    Affects Versions: 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Similar to FLINK-9822, it would be helpful for the user to have example Kubernetes deployment
files to start a standalone job cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message