flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9807) Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized
Date Fri, 13 Jul 2018 06:04:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542572#comment-16542572
] 

ASF GitHub Bot commented on FLINK-9807:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6305#discussion_r202249510
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
    @@ -99,11 +110,21 @@
     
     	private AbstractStateBackend stateBackend;
     
    +	@Parameterized.Parameter
    +	public StateBackendEnum stateBackendEnum;
    +
     	enum StateBackendEnum {
     		MEM, FILE, ROCKSDB_FULLY_ASYNC, ROCKSDB_INCREMENTAL, ROCKSDB_INCREMENTAL_ZK, MEM_ASYNC,
FILE_ASYNC
     	}
     
    -	protected abstract StateBackendEnum getStateBackend();
    +	@Parameterized.Parameters(name = "statebackend type ={0}")
    +	public static Collection<StateBackendEnum> parameter() {
    +		return Arrays.asList(MEM, FILE, ROCKSDB_FULLY_ASYNC, ROCKSDB_INCREMENTAL, ROCKSDB_INCREMENTAL_ZK,
MEM_ASYNC, FILE_ASYNC);
    --- End diff --
    
    Here we could say `Arrays.asList(StateBackendEnum.values())`.


> Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-9807
>                 URL: https://issues.apache.org/jira/browse/FLINK-9807
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Congxian Qiu
>            Assignee: Congxian Qiu
>            Priority: Major
>              Labels: pull-request-available
>
> Now, the `AbastractEventTimeWIndowCheckpointITCase` and `AbstractLocalRecoveryITCase`
need to re-implement for every backend, we can improve this by using JUnit parameterized



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message