flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9807) Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized
Date Thu, 12 Jul 2018 11:30:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541495#comment-16541495
] 

ASF GitHub Bot commented on FLINK-9807:
---------------------------------------

Github user klion26 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6305#discussion_r202000999
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
    @@ -871,19 +892,40 @@ public IntType(int value) {
     		}
     	}
     
    -	protected int numElementsPerKey() {
    -		return 300;
    +	private int numElementsPerKey() {
    +		switch (this.stateBackendEnum) {
    +			case ROCKSDB_FULLY_ASYNC:
    +			case ROCKSDB_INCREMENTAL:
    +			case ROCKSDB_INCREMENTAL_ZK:
    +				return 3000;
    +			default:
    +			return 300;
    --- End diff --
    
    yes, thank you, just fixed it.


> Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-9807
>                 URL: https://issues.apache.org/jira/browse/FLINK-9807
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Congxian Qiu
>            Priority: Major
>              Labels: pull-request-available
>
> Now, the `AbastractEventTimeWIndowCheckpointITCase` and `AbstractLocalRecoveryITCase`
need to re-implement for every backend, we can improve this by using JUnit parameterized



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message