flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9766) Incomplete/incorrect cleanup in RemoteInputChannelTest
Date Thu, 12 Jul 2018 09:47:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541398#comment-16541398
] 

ASF GitHub Bot commented on FLINK-9766:
---------------------------------------

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/6271
  
    merging...


> Incomplete/incorrect cleanup in RemoteInputChannelTest
> ------------------------------------------------------
>
>                 Key: FLINK-9766
>                 URL: https://issues.apache.org/jira/browse/FLINK-9766
>             Project: Flink
>          Issue Type: Bug
>          Components: Network, Tests
>    Affects Versions: 1.4.0, 1.5.0, 1.4.1, 1.4.2, 1.5.1
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2, 1.6.0
>
>
> If an assertion in the tests fails and as a result the cleanup code wrapped into a {{finally}}
block also fails, in most tests the original assertion was swallowed making it hard to debug
> in the successful case.
> Furthermore, {{testConcurrentRecycleAndRelease2()}} does even not clean up at all if
successful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message