flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9730) avoid access static via class reference
Date Thu, 05 Jul 2018 16:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533895#comment-16533895
] 

ASF GitHub Bot commented on FLINK-9730:
---------------------------------------

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6247#discussion_r200421156
  
    --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
    @@ -179,7 +179,7 @@ public void close() throws Exception {
     
     		@Override
     		public void asyncInvoke(final Integer input, final ResultFuture<String> resultFuture)
throws Exception {
    -			this.executorService.submit(new Runnable() {
    +			executorService.submit(new Runnable() {
    --- End diff --
    
    don't feel sorry, you are welcome.


> avoid access static via class reference
> ---------------------------------------
>
>                 Key: FLINK-9730
>                 URL: https://issues.apache.org/jira/browse/FLINK-9730
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: lamber-ken
>            Assignee: lamber-ken
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> [code refactor] access static via class reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message