flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9718) Add enviroment variable in start-scala-shell.sh to enable remote debug
Date Wed, 04 Jul 2018 09:01:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532443#comment-16532443
] 

ASF GitHub Bot commented on FLINK-9718:
---------------------------------------

Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6245#discussion_r200056172
  
    --- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
    @@ -19,6 +19,9 @@
     
     # from scala-lang 2.10.4
     
    +# Uncomment the following line to enable remote debug
    +# export FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
    --- End diff --
    
    I know there is not a env variable named "FLINK_SCALA_SHELL_JAVA_OPTS" before you create.
I said, it is commented, but you always used in "java" command later.
    About the bool flag, I mean we could add a flag named "remoteDebugMode" to control the
"export" operation. 
    
    for example : 
    
    ```
    if $remoteDebugMode then 
    export FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
    fi
    ```
    
    It's better than "comment" & "uncomment". Why do you think it hides the details of
remote debug info?


> Add enviroment variable in start-scala-shell.sh to enable remote debug
> ----------------------------------------------------------------------
>
>                 Key: FLINK-9718
>                 URL: https://issues.apache.org/jira/browse/FLINK-9718
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message