flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9491) Implement timer data structure based on RocksDB
Date Tue, 03 Jul 2018 13:37:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531393#comment-16531393

ASF GitHub Bot commented on FLINK-9491:

Github user azagrebin commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
    @@ -0,0 +1,341 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.state.heap;
    +import org.apache.flink.runtime.state.InternalPriorityQueue;
    +import org.apache.flink.util.CloseableIterator;
    +import javax.annotation.Nonnegative;
    +import javax.annotation.Nonnull;
    +import javax.annotation.Nullable;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.Comparator;
    +import java.util.Iterator;
    +import java.util.NoSuchElementException;
    +import static org.apache.flink.util.CollectionUtil.MAX_ARRAY_SIZE;
    + * Basic heap-based priority queue for {@link HeapPriorityQueueElement} objects. This
heap supports fast deletes
    + * because it manages position indexes of the contained {@link HeapPriorityQueueElement}s.
The heap implementation is
    + * a simple binary tree stored inside an array. Element indexes in the heap array start
at 1 instead of 0 to make array
    + * index computations a bit simpler in the hot methods. Object identification of remove
is based on object identity and
    --- End diff --
    I would describe it: based on its index in the internal array, also in `remove` doc comment

> Implement timer data structure based on RocksDB
> -----------------------------------------------
>                 Key: FLINK-9491
>                 URL: https://issues.apache.org/jira/browse/FLINK-9491
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
> We can now implement timer state that is stored in RocksDB for users that run the {{RocksDBKeyedStateBackend}}.
As explained in the design document (https://docs.google.com/document/d/1XbhJRbig5c5Ftd77d0mKND1bePyTC26Pz04EvxdA7Jc/edit#heading=h.17v0k3363r6q)
this should also give us asynchronous and incremental snapshots for timer state that is larger
than main memory.
> We need to think about a way in which to user can select either to run timers on RocksDB
or on the heap when using the {{RocksDBKeyedStateBackend}}.

This message was sent by Atlassian JIRA

View raw message