flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend
Date Mon, 09 Jul 2018 13:59:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536945#comment-16536945
] 

ASF GitHub Bot commented on FLINK-9486:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6276#discussion_r201010986
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupedInternalPriorityQueue.java
---
    @@ -0,0 +1,31 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state;
    +
    +import javax.annotation.Nonnull;
    +
    +import java.util.Set;
    +
    +/**
    + *
    --- End diff --
    
    Even if it is a temporary commit please add java docs in the commit where you add the
interface.


> Introduce TimerState in keyed state backend
> -------------------------------------------
>
>                 Key: FLINK-9486
>                 URL: https://issues.apache.org/jira/browse/FLINK-9486
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> This is the first implementation subtask.
> Goal of this PR is to introduce a timer state that is registered with the keyed state
backend, similar to other forms of keyed state.
> For the {{HeapKeyedStateBackend}}, this state lives on the same level as the {{StateTable}}
that hold other forms of keyed state, and the implementation is basically backed by {{InternalTimerHeap}}.
> For {{RocksDBKeyedStateBackend}}, in this first step, we also introduce this state, outside
of RocksDB and based upon {{InternalTimerHeap}}. This is an intermediate state, and we will
later also implement the alternative to store the timers inside a column families in RocksDB.
However, by taking this step, we could also still offer the option to have RocksDB state with
heap-based timers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message