flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files
Date Tue, 03 Jul 2018 09:27:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531094#comment-16531094
] 

ASF GitHub Bot commented on FLINK-9280:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6203#discussion_r199741252
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java
---
    @@ -18,64 +18,118 @@
     
     package org.apache.flink.runtime.rest.messages.job;
     
    -import org.apache.flink.runtime.jobgraph.JobGraph;
     import org.apache.flink.runtime.rest.messages.RequestBody;
    -import org.apache.flink.util.Preconditions;
     
     import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
     import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
     
    -import java.io.ByteArrayOutputStream;
    -import java.io.IOException;
    -import java.io.ObjectOutputStream;
    -import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.Objects;
     
     /**
      * Request for submitting a job.
      *
    - * <p>We currently require the job-jars to be uploaded through the blob-server.
    + * <p>This request only contains the names of files that must be present on the
server, and defines how these files are
    + * interpreted.
      */
     public final class JobSubmitRequestBody implements RequestBody {
     
    -	private static final String FIELD_NAME_SERIALIZED_JOB_GRAPH = "serializedJobGraph";
    +	private static final String FIELD_NAME_JOB_GRAPH = "jobGraphFileName";
    +	private static final String FIELD_NAME_JOB_JARS = "jobJarFileNames";
    +	private static final String FIELD_NAME_JOB_ARTIFACTS = "jobArtifactFileNames";
     
    -	/**
    -	 * The serialized job graph.
    -	 */
    -	@JsonProperty(FIELD_NAME_SERIALIZED_JOB_GRAPH)
    -	public final byte[] serializedJobGraph;
    +	@JsonProperty(FIELD_NAME_JOB_GRAPH)
    +	public final String jobGraphFileName;
     
    -	public JobSubmitRequestBody(JobGraph jobGraph) throws IOException {
    -		this(serializeJobGraph(jobGraph));
    -	}
    +	@JsonProperty(FIELD_NAME_JOB_JARS)
    +	public final Collection<String> jarFileNames;
    +
    +	@JsonProperty(FIELD_NAME_JOB_ARTIFACTS)
    +	public final Collection<DistributedCacheFile> artifactFileNames;
     
    -	@JsonCreator
    --- End diff --
    
    revert


> Extend JobSubmitHandler to accept jar files
> -------------------------------------------
>
>                 Key: FLINK-9280
>                 URL: https://issues.apache.org/jira/browse/FLINK-9280
>             Project: Flink
>          Issue Type: New Feature
>          Components: Job-Submission, REST
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0, 1.5.1
>
>
> The job submission through the CLI first uploads all require jars to the blob server,
sets the blob keys in the jobgraph, and then uploads this graph to The {{JobSubmitHandler}}
which submits it to the Dispatcher.
> This process has the downside that it requires jars to be uploaded to the blobserver
before submitting the job graph, which does not happen via REST.
> I propose an extension to the the {{JobSubmitHandler}} to also accept an optional list
of jar files, that were previously uploaded through the {{JarUploadHandler}}. If present,
the handler would upload these jars to the blobserver and set the blob keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message