flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9240) Avoid deprecated akka methods
Date Sat, 28 Jul 2018 23:04:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560923#comment-16560923
] 

ASF GitHub Bot commented on FLINK-9240:
---------------------------------------

TisonKun commented on a change in pull request #6446: [FLINK-9240] Avoid deprecated Akka methods
URL: https://github.com/apache/flink/pull/6446#discussion_r205956045
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/akka/DefaultQuarantineHandler.java
 ##########
 @@ -65,11 +66,13 @@ public void hasQuarantined(String remoteSystem, ActorSystem actorSystem)
{
 
 	private void shutdownActorSystem(ActorSystem actorSystem) {
 		// shut the actor system down
-		actorSystem.shutdown();
+		actorSystem.terminate();
 
 		try {
 			// give it some time to complete the shutdown
-			actorSystem.awaitTermination(timeout);
+			Await.ready(actorSystem.whenTerminated(), timeout);
+		} catch (InterruptedException | java.util.concurrent.TimeoutException e) {
 
 Review comment:
   `java.util.concurrent.TimeoutException` could be simplified.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Avoid deprecated akka methods
> -----------------------------
>
>                 Key: FLINK-9240
>                 URL: https://issues.apache.org/jira/browse/FLINK-9240
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client, Local Runtime, Mesos, Tests, Web Client, YARN
>    Affects Versions: 1.6.0
>            Reporter: Arnout Engelen
>            Priority: Minor
>              Labels: pull-request-available
>
> Several Akka functions that are widely-used in Flink have been deprecated for a long
time, such as ActorSystem#shutdown() and ActorSystem.awaitTermination(). It would be nice
to update those to use non-deprecated functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message