flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery
Date Fri, 06 Jul 2018 14:33:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534898#comment-16534898
] 

ASF GitHub Bot commented on FLINK-8558:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r200670463
  
    --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSource.java
---
    @@ -18,48 +18,99 @@
     
     package org.apache.flink.streaming.connectors.kafka;
     
    -import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.annotation.Internal;
     import org.apache.flink.api.common.serialization.DeserializationSchema;
     import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.streaming.connectors.kafka.config.StartupMode;
    +import org.apache.flink.streaming.connectors.kafka.internals.KafkaTopicPartition;
     import org.apache.flink.table.api.TableSchema;
    +import org.apache.flink.table.sources.RowtimeAttributeDescriptor;
     import org.apache.flink.table.sources.StreamTableSource;
     import org.apache.flink.types.Row;
     
    +import java.util.List;
    +import java.util.Map;
     import java.util.Properties;
     
     /**
      * Kafka {@link StreamTableSource} for Kafka 0.10.
      */
    -@PublicEvolving
    -public abstract class Kafka010TableSource extends KafkaTableSource {
    +@Internal
    +public class Kafka010TableSource extends KafkaTableSource {
     
    -	// The deserialization schema for the Kafka records
    -	private final DeserializationSchema<Row> deserializationSchema;
    +	/**
    +	 * Creates a Kafka 0.10 {@link StreamTableSource}.
    +	 *
    +	 * @param schema                      Schema of the produced table.
    +	 * @param proctimeAttribute           Field name of the processing time attribute, null
if no
    --- End diff --
    
    Replace null with `Optional`


> Add unified format interfaces and format discovery
> --------------------------------------------------
>
>                 Key: FLINK-8558
>                 URL: https://issues.apache.org/jira/browse/FLINK-8558
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> In the last release, we introduced a new module {{flink-formats}}. Currently only {{flink-avro}}
is located there but we will add more formats such as {{flink-json}}, {{flink-protobuf}},
and so on. For better separation of concerns we want decouple connectors from formats: e.g.,
remove {{KafkaAvroTableSource}} and {{KafkaJsonTableSource}}.
> A newly introduced {{FormatFactory}} will use Java service loaders to discovery available
formats in the classpath (similar to how file systems are discovered now). A {{Format}} will
provide a method for converting {{byte[]}} to target record type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message