flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8523) Stop assigning floating buffers for blocked input channels in exactly-once mode
Date Thu, 26 Jul 2018 19:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558793#comment-16558793
] 

ASF GitHub Bot commented on FLINK-8523:
---------------------------------------

NicoK commented on a change in pull request #5381: [FLINK-8523][network] Stop assigning floating
buffers for blocked input channels in exactly-once mode
URL: https://github.com/apache/flink/pull/5381#discussion_r205572919
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
 ##########
 @@ -66,6 +66,9 @@
 	/** The current backoff (in ms) */
 	private int currentBackoff;
 
+	/** Flag indicating whether this channel is currently blocked or not. */
+	private volatile boolean isBlocked = false;
 
 Review comment:
   Does it make sense to have it in the `LocalInputChannel` then? I guess, we should not add
dead code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Stop assigning floating buffers for blocked input channels in exactly-once mode
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-8523
>                 URL: https://issues.apache.org/jira/browse/FLINK-8523
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Major
>              Labels: pull-request-available
>
> In exactly-once mode, the input channel is set blocked state when reading barrier from
it. And the blocked state will be released after barrier alignment or cancelled.
>  
> In credit-based network flow control, we should avoid assigning floating buffers for
blocked input channels because the buffers after barrier will not be processed by operator
until alignment.
> To do so, we can fully make use of floating buffers and speed up barrier alignment in
some extent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message