flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core
Date Sun, 15 Jul 2018 20:10:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544657#comment-16544657
] 

ASF GitHub Bot commented on FLINK-7251:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r202552984
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
    @@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class<? extends TypeInfoFactory>
fac
     				// number of parameters the SAM of implemented interface has; the parameter indexing
applies to this range
     				final int baseParametersLen = sam.getParameterTypes().length;
     
    -				// executable references "this" implicitly
    -				if (paramLen <= 0) {
    --- End diff --
    
    The input validation caused more errors than it solved. Especially with generic types.
For lambdas this validation is limited anyway in a JDK compiler.


> Merge the flink-java8 project into flink-core
> ---------------------------------------------
>
>                 Key: FLINK-7251
>                 URL: https://issues.apache.org/jira/browse/FLINK-7251
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message