flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core
Date Tue, 17 Jul 2018 15:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546758#comment-16546758
] 

ASF GitHub Bot commented on FLINK-7251:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r203060212
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
---
    @@ -102,15 +104,62 @@ public void TestAnonymousInnerClassTrick4() throws Exception {
     		jfc.addClass(NestedAnonymousInnerClass.class)
     			.createJarFile();
     
    -		Set<String> ans = new HashSet<String>();
    +		Set<String> ans = new HashSet<>();
     		ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass.class");
     		ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1$1.class");
     		ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1.class");
     		ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$A.class");
     
     		Assert.assertTrue("Jar file for Anonymous Inner Class is not correct", validate(ans,
out));
     
    -		out.delete();
    +		Assert.assertTrue(out.delete());
    +	}
    +
    +	@Ignore // this is currently not supported (see FLINK-9520)
    +	@Test
    +	public void testFilterWithMethodReference() throws Exception {
    --- End diff --
    
    It was a util for programmatically creating Jar files. I think it's only used in tests
right now, for example `ClassLoaderUtilsTest`.


> Merge the flink-java8 project into flink-core
> ---------------------------------------------
>
>                 Key: FLINK-7251
>                 URL: https://issues.apache.org/jira/browse/FLINK-7251
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message