flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6846) Add TIMESTAMPADD supported in TableAPI
Date Wed, 04 Jul 2018 06:47:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532346#comment-16532346
] 

ASF GitHub Bot commented on FLINK-6846:
---------------------------------------

Github user xueyumusic commented on the issue:

    https://github.com/apache/flink/pull/6188
  
    @twalthr I looked around and realized that current `+` expression could support TimeInterval
(TimePoint) addition, thus the timestampAdd api is duplicated and seems have no necessary.

    
    so I only made these changes:
    1. add `1.week` expression
    2. modify `quarter` as `1.quarter` 
    3. modify Extract to support extracting QUARTER and WEEK, as suggested and verified by
@walterddr 
    
    Please have a review, @twalthr @fhueske @walterddr @hequn8128  thanks for all of you,


> Add TIMESTAMPADD supported in TableAPI
> --------------------------------------
>
>                 Key: FLINK-6846
>                 URL: https://issues.apache.org/jira/browse/FLINK-6846
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>              Labels: pull-request-available, starter
>
> See FLINK-6811 for detail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message