flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5860) Replace all the file creating from java.io.tmpdir with TemporaryFolder
Date Tue, 24 Jul 2018 11:50:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554154#comment-16554154
] 

ASF GitHub Bot commented on FLINK-5860:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6399#discussion_r204720983
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java
---
    @@ -225,7 +224,13 @@ public void testSortingDataSinkTask() {
     		super.getTaskConfig().setFilehandlesInput(0, 8);
     		super.getTaskConfig().setSpillingThresholdInput(0, 0.8f);
     
    -		super.registerFileOutputTask(MockOutputFormat.class, new File(tempTestPath).toURI().toString());
    +		File tempTestFile = null;
    +		try {
    +			tempTestFile = tempFolder.newFile(tempTestFileName);
    --- End diff --
    
    same issue as in `JarFileCreatorTest`


> Replace all the file creating from java.io.tmpdir with TemporaryFolder
> ----------------------------------------------------------------------
>
>                 Key: FLINK-5860
>                 URL: https://issues.apache.org/jira/browse/FLINK-5860
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>            Reporter: shijinkui
>            Assignee: Mahesh Senniappan
>            Priority: Major
>              Labels: pull-request-available, starter
>
> Search `System.getProperty("java.io.tmpdir")` in whole Flink project. It will get a 
Unit test list. Replace all the file creating from `java.io.tmpdir` with TemporaryFolder.
> Who can fix this problem thoroughly?
> ```
> $ grep -ri 'System.getProperty("java.io.tmpdir")' .
> ./flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/example/CassandraTupleWriteAheadSinkExample.java:
env.setStateBackend(new FsStateBackend("file:///" + System.getProperty("java.io.tmpdir") +
"/flink/backend"));
> ./flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java:
	File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java:
	File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java:
	File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java:
	return getMockEnvironment(new File[] { new File(System.getProperty("java.io.tmpdir")) });
> ./flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:	public
static final String DEFAULT_TASK_MANAGER_TMP_PATH = System.getProperty("java.io.tmpdir");
> ./flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java:
final String tempPath = System.getProperty("java.io.tmpdir");
> ./flink-core/src/test/java/org/apache/flink/testutils/TestConfigUtils.java:		final File
tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java:		File tempDir
= new File(System.getProperty("java.io.tmpdir"));
> ./flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java:		File tempDir
= new File(System.getProperty("java.io.tmpdir"));
> ./flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/util/KMeansDataGenerator.java:
	final String outDir = params.get("output", System.getProperty("java.io.tmpdir"));
> ./flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/util/LinearRegressionDataGenerator.java:
	final String tmpDir = System.getProperty("java.io.tmpdir");
> ./flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/util/WebLogDataGenerator.java:
	final String outPath = System.getProperty("java.io.tmpdir");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java:
public static final String FLINK_PYTHON_FILE_PATH = System.getProperty("java.io.tmpdir") +
File.separator + "flink_plan";
> ./flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java:
public static final String FLINK_TMP_DATA_DIR = System.getProperty("java.io.tmpdir") + File.separator
+ "flink_data";
> ./flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java:
			FLINK_HDFS_PATH = "file:" + System.getProperty("java.io.tmpdir") + File.separator + "flink";
> ./flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java:			baseDir
= new File(System.getProperty("java.io.tmpdir"));
> ./flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java:
	return System.getProperty("java.io.tmpdir");
> ./flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/FlinkZooKeeperQuorumPeer.java:
				System.getProperty("java.io.tmpdir"), UUID.randomUUID().toString());
> ./flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializationTest.java:
				new String[] { System.getProperty("java.io.tmpdir") });
> ./flink-runtime/src/test/java/org/apache/flink/runtime/io/network/serialization/LargeRecordsTest.java:
						new String[] { System.getProperty("java.io.tmpdir") } );
> ./flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java:
	String path = System.getProperty("java.io.tmpdir");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStateOutputStreamTest.java:
private static final Path TEMP_DIR_PATH = new Path(new File(System.getProperty("java.io.tmpdir")).toURI());
> ./flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java:
	File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
	File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/TestingTaskManagerRuntimeInfo.java:
	this(new Configuration(), System.getProperty("java.io.tmpdir").split(",|" + File.pathSeparator));
> ./flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java:
	return configuration.getString(ConfigConstants.JOB_MANAGER_WEB_TMPDIR_KEY, System.getProperty("java.io.tmpdir"));
> ./flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala:     
System.getProperty("java.io.tmpdir"),
> ./flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java:
		new TestingTaskManagerRuntimeInfo(taskManagerConfig, new String[] {System.getProperty("java.io.tmpdir")}),
> ./flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java:
	String path = System.getProperty("java.io.tmpdir");
> ./flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/CommonTestUtils.java:
	return System.getProperty("java.io.tmpdir");
> ./flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java:		String
defaultPropertiesFileLocation = System.getProperty("java.io.tmpdir");
> ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message