flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...
Date Wed, 25 Jul 2018 06:57:47 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r204758828
  
    --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
---
    @@ -176,7 +175,7 @@ public void setDelayMillis(long delayMillis) {
     	private AtomicLong numPendingRequests = new AtomicLong(0);
     
     	/** Elasticsearch client created using the call bridge. */
    -	private transient Client client;
    +	private transient AutoCloseable client;
    --- End diff --
    
    Same here. Why not parameterize the class and be type save?


---

Mime
View raw message