flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...
Date Mon, 23 Jul 2018 19:28:49 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6388
  
    If a feature isn't visibly documented chances are no one will use it ;)
    
    I'm not sure if the configuration page is the right place to put it, as it so far deals
exclusively with settings set in `flink-conf.yaml`. Most notable this line in the introduction
sticks out:
    
    ```
    All configuration is done in conf/flink-conf.yaml, which is expected to be a flat collection
of YAML key value pairs with format key: value.
    ```
    
    You could name it `flink-client-env-sh`, that would make it make it more obvious that
it only applies to the client.
    However i have to ask, why a separate file in the first place? We already have config
options for setting environment variables (`env.java.opts`); couldn't we introduce a separate
option for clients?


---

Mime
View raw message