flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...
Date Wed, 18 Jul 2018 13:15:55 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6363#discussion_r203373280
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java
---
    @@ -50,6 +55,24 @@
     
     	private static final ObjectMapper OBJECT_MAPPER = RestMapperUtils.getStrictObjectMapper();
     
    +	private static ResourceLeakDetectorFactory previousLeakDetector;
    +	private static ResourceLeakDetector.Level previousLeakDetectorLevel;
    +
    +	@BeforeClass
    +	public static void setLeakDetector() {
    --- End diff --
    
    we could move this into a utility `LeakDetectorResource` so we can re-use it for any test
by simply adding it as a `@Rule`.


---

Mime
View raw message