flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanghua <...@git.apache.org>
Subject [GitHub] flink pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQ...
Date Wed, 18 Jul 2018 06:44:00 GMT
Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6359#discussion_r203265891
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/StrToDateCallGen.scala
---
    @@ -0,0 +1,45 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.codegen.calls
    +
    +import org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo
    +import org.apache.flink.table.codegen.calls.CallGenerator.generateCallIfArgsNotNull
    +import org.apache.flink.table.codegen.{CodeGenerator, GeneratedExpression}
    +import org.apache.flink.table.runtime.functions.DateTimeFunctions
    +
    +class StrToDateCallGen extends CallGenerator {
    --- End diff --
    
    if provide class doc, it would be better


---

Mime
View raw message