flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...
Date Tue, 17 Jul 2018 12:43:13 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r203001023
  
    --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java
---
    @@ -50,12 +41,12 @@
     import static org.junit.Assert.assertEquals;
     import static org.junit.Assert.assertNotNull;
     import static org.junit.Assert.assertNull;
    -import static org.junit.Assert.fail;
    +import static org.junit.Assert.assertTrue;
     
     /**
    - * Tests the type extractor for lambda functions.
    + * Tests the type extractor for lambda functions. Many tests only work if the compiler
supports
    --- End diff --
    
    Some tests, like `flatMapLambda()` are not there anymore? It's because we don't use Tycho
anymore but do theses tests now reside somewhere else? If not, we should probably have a new
module `flink-tycho-lambda-tests` where we test those things that only work with Tycho. Otherwise
we lose that coverage.


---

Mime
View raw message