flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...
Date Sun, 15 Jul 2018 09:02:12 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202536081
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
    @@ -173,55 +180,92 @@ public void open() {
     			if (line == null || line.equals("")) {
     				continue;
     			}
    +			parseAndCall(line);
    +		}
    +	}
     
    -			final SqlCommandCall cmdCall = SqlCommandParser.parse(line);
    +	/**
    +	 * Submits a SQL update statement and prints status information and/or errors on the
terminal.
    +	 *
    +	 * @param statement SQL update statement
    +	 * @return flag to indicate if the submission was successful or not
    +	 */
    +	public boolean submitUpdate(String statement) {
    --- End diff --
    
    I added some unit tests.


---

Mime
View raw message