flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sihuazhou <...@git.apache.org>
Subject [GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...
Date Sat, 14 Jul 2018 16:26:37 GMT
Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6333#discussion_r202517181
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java
---
    @@ -85,10 +85,10 @@ public int compare(T o1, T o2) {
     			return ((Comparable<T>) o1).compareTo(o2);
     		}
     
    -		// we catch this case before moving to more expensive tie breaks.
    -		if (o1.equals(o2)) {
    -			return 0;
    -		}
    +//		// we catch this case before moving to more expensive tie breaks.
    --- End diff --
    
    For what reason we need to comment this.


---

Mime
View raw message