flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...
Date Fri, 13 Jul 2018 14:07:54 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202356170
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/CsvTableSinkFactory.scala
---
    @@ -104,17 +100,12 @@ class CsvTableSinkFactory
             "Encodings that differ from the schema are not supported yet for CsvTableSink.")
         }
     
    -    toScala(params.getOptionalString(CONNECTOR_PATH))
    -      .foreach(csvTableSinkBuilder.path)
    -    toScala(params.getOptionalInt(NUM_FILES))
    -      .foreach(n => csvTableSinkBuilder.numFiles(n))
    -    toScala(params.getOptionalString(WRITE_MODE))
    -      .foreach(csvTableSinkBuilder.writeMode)
    -    toScala(params.getOptionalString(FORMAT_FIELD_DELIMITER))
    -      .foreach(csvTableSinkBuilder.fieldDelimiter)
    -
    -    csvTableSinkBuilder
    -      .build()
    +    val path = params.getString(CONNECTOR_PATH)
    --- End diff --
    
    ditto fixup


---

Mime
View raw message