flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...
Date Fri, 13 Jul 2018 14:07:49 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202282625
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableSinkDescriptor.scala
---
    @@ -22,9 +22,11 @@ package org.apache.flink.table.descriptors
       * Common class for all descriptors describing a table sink.
       */
     abstract class TableSinkDescriptor extends TableDescriptor {
    +
    +  /**
    +    * Internal method for properties conversion.
    +    */
       override private[flink] def addProperties(properties: DescriptorProperties): Unit =
{
         super.addProperties(properties)
    -    properties.putString(TableDescriptorValidator.TABLE_TYPE,
    -      TableDescriptorValidator.TABLE_TYPE_VALUE_SOURCE)
    --- End diff --
    
    why did those lines disappear?


---

Mime
View raw message