flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...
Date Fri, 13 Jul 2018 13:51:03 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6312#discussion_r202355843
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
    @@ -0,0 +1,40 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.configuration.description;
    +
    +/**
    + * Represents a line break in the {@link Description}.
    + */
    +public class LineBreakElement implements BlockElement {
    +
    +	/**
    +	 * Creates a line break in the description.
    +	 */
    +	public static LineBreakElement linebreak() {
    +		return new LineBreakElement();
    +	}
    +
    +	private LineBreakElement() {
    +	}
    +
    +	@Override
    +	public String format(Formatter formatter) {
    +		return formatter.format(this);
    --- End diff --
    
    yes, nesting is an orthogonal issue.
    
    For the nesting I suggest to change `Text` to implement `BlockElement` instead; it then
effectively behaves like `Sequence`. At the moment i don't see a use-case for inserting Text
into the format String since it could just be part of the format string.
    
    I mean, when would this make sense?
    ```
    text("hello %s", text("world"))
    ``


---

Mime
View raw message