flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #6320: [FLINK-9823] Add Kubernetes deployment ymls
Date Fri, 13 Jul 2018 12:18:29 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6320#discussion_r202300255
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterConfigurationParserFactoryTest.java
---
    @@ -0,0 +1,82 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.entrypoint;
    +
    +import org.apache.flink.runtime.entrypoint.parser.CommandLineParser;
    +import org.apache.flink.util.TestLogger;
    +
    +import org.junit.Test;
    +
    +import java.util.Properties;
    +
    +import static org.hamcrest.Matchers.arrayContaining;
    +import static org.hamcrest.Matchers.equalTo;
    +import static org.hamcrest.Matchers.hasEntry;
    +import static org.hamcrest.Matchers.is;
    +import static org.junit.Assert.assertThat;
    +import static org.junit.Assert.fail;
    +
    +/**
    + * Tests for the {@link ClusterConfigurationParserFactory}.
    + */
    +public class ClusterConfigurationParserFactoryTest extends TestLogger {
    +
    +	@Test
    +	public void testEntrypointClusterConfigurationParsing() throws FlinkParseException {
    +		final CommandLineParser<ClusterConfiguration> commandLineParser = new CommandLineParser<>(new
ClusterConfigurationParserFactory());
    +
    +		final String configDir = "/foo/bar";
    +		final String key = "key";
    +		final String value = "value";
    +		final String arg1 = "arg1";
    +		final String arg2 = "arg2";
    +		final String[] args = {"--configDir", configDir, String.format("-D%s=%s", key, value),
arg1, arg2};
    +
    +		final ClusterConfiguration clusterConfiguration = commandLineParser.parse(args);
    +
    +		assertThat(clusterConfiguration.getConfigDir(), is(equalTo(configDir)));
    +		final Properties dynamicProperties = clusterConfiguration.getDynamicProperties();
    +
    +		assertThat(dynamicProperties, hasEntry(key, value));
    +
    +		assertThat(clusterConfiguration.getArgs(), arrayContaining(arg1, arg2));
    +	}
    +
    +	@Test
    +	public void testOnlyRequiredArguments() throws FlinkParseException {
    +		final CommandLineParser<ClusterConfiguration> commandLineParser = new CommandLineParser<>(new
ClusterConfigurationParserFactory());
    +
    +		final String configDir = "/foo/bar";
    +		final String[] args = {"--configDir", configDir};
    +
    +		final ClusterConfiguration clusterConfiguration = commandLineParser.parse(args);
    +
    +		assertThat(clusterConfiguration.getConfigDir(), is(equalTo(configDir)));
    +	}
    +
    +	@Test(expected = FlinkParseException.class)
    +	public void testMissingRequiredArgument() throws FlinkParseException {
    +		final CommandLineParser<ClusterConfiguration> commandLineParser = new CommandLineParser<>(new
ClusterConfigurationParserFactory());
    +		final String[] args = {};
    +
    +		commandLineParser.parse(args);
    +		fail("Expected an FlinkParseException.");
    --- End diff --
    
    Superfluous `fail`


---

Mime
View raw message