flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanghua <...@git.apache.org>
Subject [GitHub] flink pull request #6297: [FLINK-9777] YARN: JM and TM Memory must be specif...
Date Thu, 12 Jul 2018 15:19:14 GMT
Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6297#discussion_r202075216
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -386,10 +386,10 @@ private ClusterSpecification createClusterSpecification(Configuration
configurat
     		}
     
     		// JobManager Memory
    -		final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
    +		final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
    --- End diff --
    
    introduce a new config key is used to make the `jobmanager.heap.mb` backwards compatibility
in flink config file (config.sh can calculate it accurately). And user can specify the unit
for the value of the key `jobmanager.heap.size` .
    
    So if we remove anything about `JOB_MANAGER_HEAP_MEMORY_MB ` in Java and Scala code, is
there any problem?


---

Mime
View raw message