flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanghua <...@git.apache.org>
Subject [GitHub] flink pull request #6297: [FLINK-9777] YARN: JM and TM Memory must be specif...
Date Thu, 12 Jul 2018 11:14:26 GMT
Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6297#discussion_r201997464
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -386,10 +386,10 @@ private ClusterSpecification createClusterSpecification(Configuration
configurat
     		}
     
     		// JobManager Memory
    -		final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
    +		final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
    --- End diff --
    
    in FLINK-6469, in order to config the jm's memory with unit I introduced a new key and
deprecated `jobmanager.heap.mb`.
    
    * in flink codebase(except shell script) I have removed all the place used `JOB_MANAGER_HEAP_MEMORY_MB`
and `jobmanager.heap.mb`, so it will not be used.
    * in shell (`config.sh`) the old key `jobmanager.heap.mb` also be supported if the new
key `jobmanager.heap.size` can not be read, so it still be supported.
    
     


---

Mime
View raw message