flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...
Date Mon, 09 Jul 2018 14:51:47 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r200998882
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactoryService.scala
---
    @@ -139,9 +139,14 @@ object TableSourceFactoryService extends Logging {
           Seq[String]()
         }
     
    +    // extract wildcard prefixes
    --- End diff --
    
    please extract at least both `// extract wildcard prefixes` and `// check for supported
properties` into separate method (this method is already too large)


---

Mime
View raw message