flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...
Date Mon, 09 Jul 2018 14:51:47 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r200999721
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/TableSourceDescriptorTest.scala
---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.descriptors
    +
    +import org.apache.flink.table.api.Types
    +import org.apache.flink.table.utils.TableTestBase
    +import org.junit.Assert.assertEquals
    +import org.junit.Test
    +
    +import scala.collection.JavaConverters._
    +
    +class TableSourceDescriptorTest extends TableTestBase {
    +
    +  @Test
    +  def testStreamTableSourceDescriptor(): Unit = {
    +    val util = streamTestUtil()
    +    val desc = util.tableEnv
    +      .from(
    +        FileSystem()
    +          .path("/path/to/csv"))
    +      .withFormat(
    +        Csv()
    +          .field("myfield", Types.STRING)
    +          .field("myfield2", Types.INT)
    +          .quoteCharacter(';')
    +          .fieldDelimiter("#")
    +          .lineDelimiter("\r\n")
    +          .commentPrefix("%%")
    +          .ignoreFirstLine()
    +          .ignoreParseErrors())
    +        .withSchema(
    +          Schema()
    +            .field("myfield", Types.STRING)
    +            .field("myfield2", Types.INT)
    +            .field("proctime", Types.SQL_TIMESTAMP).proctime()
    +        )
    +    val expected = Seq(
    --- End diff --
    
    Ditto. `expectedProperties`? 


---

Mime
View raw message