flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...
Date Mon, 09 Jul 2018 14:51:47 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r201002716
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
    @@ -0,0 +1,245 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.formats
    +
    +import java.util.{ServiceConfigurationError, ServiceLoader, Map => JMap}
    +
    +import org.apache.flink.table.api._
    +import org.apache.flink.table.descriptors.FormatDescriptorValidator.FORMAT_PROPERTY_VERSION
    +import org.apache.flink.table.descriptors._
    +import org.apache.flink.table.util.Logging
    +
    +import _root_.scala.collection.JavaConverters._
    +import _root_.scala.collection.mutable
    +
    +/**
    +  * Service provider interface for finding a suitable [[TableFormatFactory]] for the
    +  * given properties.
    +  */
    +object TableFormatFactoryService extends Logging {
    +
    +  private lazy val defaultLoader = ServiceLoader.load(classOf[TableFormatFactory[_]])
    +
    +  /**
    +    * Finds a table format factory of the given class and creates configured instances
from the
    +    * given descriptor.
    +    *
    +    * @param factoryClass desired format factory
    +    * @param descriptor descriptor that describes the format
    +    * @tparam T factory class type
    +    * @return configured instance from factory
    +    */
    +  def find[T](factoryClass: Class[T], descriptor: Descriptor): T = {
    +    find(factoryClass, descriptor, null)
    --- End diff --
    
    `Option[ClassLoader]` - same argument as before regarding nulls


---

Mime
View raw message