flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From suez1224 <...@git.apache.org>
Subject [GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...
Date Mon, 09 Jul 2018 04:22:22 GMT
GitHub user suez1224 reopened a pull request:

    https://github.com/apache/flink/pull/6201

    [FLINK-8866][Table API & SQL] Add support for unified table sink instantiation

    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    
    Add interfaces to support unified table sink configuration and instantiation. Consolidate
table source and table sink configuration and instantiation.
    
    
    ## Brief change log
    
    - Consolidate table sink and table source instantiation with TableConnectorFactory{Service}.
    - Add support to register a Calcite table with both tableSource and tableSink.
    - Add Insert command support in SQL client.
    - Add CsvTableSinkFactory.
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Added integration tests for testing registering table source and sink tables under
the same name. 
      - *Added integration tests for testing insert into command in sql client.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/suez1224/flink FLINK-8866-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6201
    
----
commit d436041fda022f405fa3a1d497b95d2ff0934ce5
Author: Shuyi Chen <shuyi@...>
Date:   2018-06-19T19:00:34Z

    - Add unified table sink instantiation.
    - Consolidate table sink and table source instantiation.
    - Add support to register a Calcite table with both tableSource and tableSink.
    - Add Insert command support in SQL client.
    - Add CsvTableSinkFactory.

commit d70d033abec0806f1723b18f7bcbab1f60ec7280
Author: Shuyi Chen <shuyi@...>
Date:   2018-06-28T18:30:21Z

    comment fixes

commit 0649359106ddfa003c44e3d0221f7f52ac507593
Author: Shuyi Chen <shuyi@...>
Date:   2018-07-06T23:31:05Z

    refactor:
    1) add TableFactoryDiscoverable trait
    2) add util for handling rowtime/proctime for table schema and unittests

----


---

Mime
View raw message