flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhangminglei <...@git.apache.org>
Subject [GitHub] flink issue #6075: [FLINK-9407] [hdfs connector] Support orc rolling sink wr...
Date Sun, 08 Jul 2018 03:11:32 GMT
Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/6075
  
    Thanks @hequn8128. You are very correct! It is more reasonable to put the ORC related
classes into there ~, like @StephanEwen said, at the very least. make them optional. As refers
to implement the ```CheckpointedFuntion```, I would not think it is necessary for it since
```BucketingSink``` have already implemented that and we just use the orc writer in this way
like ```bucketingSink.setWriter(new OrcFileWriter<>(orcSchemaString))```.Also, we can
take a look on  ```SequenceFileWriter``` and ```StringWriter``` both do not implement ```CheckpointedFuntion```.
    



---

Mime
View raw message