flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...
Date Fri, 06 Jul 2018 15:23:44 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r200687537
  
    --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka011JsonTableSourceFactory.java
---
    @@ -1,37 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one
    - * or more contributor license agreements.  See the NOTICE file
    - * distributed with this work for additional information
    - * regarding copyright ownership.  The ASF licenses this file
    - * to you under the Apache License, Version 2.0 (the
    - * "License"); you may not use this file except in compliance
    - * with the License.  You may obtain a copy of the License at
    - *
    - *     http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -
    -package org.apache.flink.streaming.connectors.kafka;
    -
    -import static org.apache.flink.table.descriptors.KafkaValidator.CONNECTOR_VERSION_VALUE_011;
    -
    -/**
    - * Factory for creating configured instances of {@link Kafka011JsonTableSource}.
    - */
    -public class Kafka011JsonTableSourceFactory extends KafkaJsonTableSourceFactory {
    --- End diff --
    
    The factories were never public API and have been introduced in the last release. The
sources were publicly documented:
    https://ci.apache.org/projects/flink/flink-docs-master/dev/table/sourceSinks.html#provided-tablesources



---

Mime
View raw message