flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...
Date Thu, 05 Jul 2018 12:57:51 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6255#discussion_r200333630
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala
---
    @@ -384,4 +386,12 @@ object HarnessTestBase {
           value.row.getField(selectorField).asInstanceOf[T]
         }
       }
    +
    +  /**
    +    * Test class used to test min and max retention time.
    +    */
    +  class StreamQueryConfigTest(min: Time, max: Time) extends StreamQueryConfig {
    --- End diff --
    
    I would rename the class to `TestStreamQueryConfig` because the `Test` at the end suggests
that this class is testing something instead of being a util for a test.


---

Mime
View raw message