flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjffdu <...@git.apache.org>
Subject [GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...
Date Tue, 03 Jul 2018 09:59:06 GMT
Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6140#discussion_r199750956
  
    --- Diff: flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
    @@ -255,14 +257,25 @@ object FlinkShell {
         yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
         yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
     
    +    val customCommandLines = CliFrontend.loadCustomCommandLines(
    +      configuration,configurationDirectory)
    +    val commandOptions = CliFrontendParser.getRunCommandOptions
    +    val customCommandLineOptions = new Options()
    +    customCommandLines.asScala.foreach(cmd => {
    --- End diff --
    
    @zentol  I have fixed that, but I have to make `customCommandLineOptions` of `CliFrontend`
to be static (a little ugly)


---

Mime
View raw message