flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support
Date Tue, 03 Jul 2018 09:33:44 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6223#discussion_r199743600
  
    --- Diff: docs/dev/table/tableApi.md ---
    @@ -2184,6 +2184,17 @@ NUMERIC.atan()
           </td>
         </tr>
     
    +    <tr>
    +      <td>
    +        {% highlight java %}
    +NUMERIC.atan2(NUMERIC)
    --- End diff --
    
    given that both parameters are equally important, we might want to change the syntax to
`atan2(Numeric, Numeric)`. IMO, that would be more intuitive. What do you think?


---

Mime
View raw message