flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sampathBhat opened a new pull request #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
Date Mon, 30 Jul 2018 09:09:55 GMT
sampathBhat opened a new pull request #6452: [FLINK-9739] Regression in supported filesystems
for RocksDB
URL: https://github.com/apache/flink/pull/6452
 
 
   Like mentioned in the description and comments of the bug -
   The issue https://issues.apache.org/jira/browse/FLINK-9739 is due to the refactoring of
the flink Path to java Files API. Secondly the usage File.isAbsolute() throws an java.lang.IllegalArgumentException:
Relative paths are not supported which should not have happened.
   
   The reason why java.lang.IllegalArgumentException is thrown is -
   The calling function is splitting the filepaths based on File.pathSeparator and in linux
systems the file seperator is ':' therefore if file paths given to state.backend.rocksdb.localdir
is of form file:///some/local/path then "file" and "/some/local/path" will be considered as
different path and would fail in the below absolute path check.
   
   Solution:
   1. Since "state.backend.rocksdb.localdir" expects only local file path an extra check can
be added to see if the path contains "file". This is the change done in this commit.
   
   2. The other possible solution could be to revert the API change from java File to flink
Path. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message