flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kl0u opened a new pull request #6449: [FLINK-9994][DataStream API] IntervalJoinOp Context#getTimestamp() returns max timestamp.
Date Sun, 29 Jul 2018 12:05:25 GMT
kl0u opened a new pull request #6449: [FLINK-9994][DataStream API] IntervalJoinOp Context#getTimestamp()
returns max timestamp.
URL: https://github.com/apache/flink/pull/6449
 
 
   ## What is the purpose of the change
   
   Although the `Context.getTimestamp()` in the `IntervalJoinOperator` should return the max
timestamp between the elements in the joined pair, it currently returns the one of the "left"
element. 
   
   This is a remain from past versions of the code, as the timestamp of the collector is correctly
updated to the max timestamp between the ones in the matched pair.
   
   ## Brief change log
   
   The main change is in the `collect(T1 left, T2 right, long leftTimestamp, long rightTimestamp)`
of the `InternalJoinOperator`.
   
   ## Verifying this change
   
   The tests that were testing this behavior were wrong and they are now fixed.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message