From issues-return-173247-archive-asf-public=cust-asf.ponee.io@flink.apache.org  Mon Jun 25 10:52:09 2018
Return-Path: <issues-return-173247-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 932D8180627
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 25 Jun 2018 10:52:08 +0200 (CEST)
Received: (qmail 99691 invoked by uid 500); 25 Jun 2018 08:52:07 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 99682 invoked by uid 99); 25 Jun 2018 08:52:07 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2018 08:52:07 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 5E92EE0A96; Mon, 25 Jun 2018 08:52:07 +0000 (UTC)
From: zentol <git@git.apache.org>
To: issues@flink.apache.org
Reply-To: issues@flink.apache.org
References: <git-pr-6199-flink@git.apache.org>
In-Reply-To: <git-pr-6199-flink@git.apache.org>
Subject: [GitHub] flink pull request #6199: [FLINK-9624][runtime] Move jar/artifact upload out...
Content-Type: text/plain
Message-Id: <20180625085207.5E92EE0A96@git1-us-west.apache.org>
Date: Mon, 25 Jun 2018 08:52:07 +0000 (UTC)

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6199#discussion_r197721680
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java ---
    @@ -114,17 +114,12 @@ public JarRunHandler(
     
     		CompletableFuture<JobGraph> jarUploadFuture = jobGraphFuture.thenCombine(blobServerPortFuture, (jobGraph, blobServerPort) -> {
     			final InetSocketAddress address = new InetSocketAddress(getDispatcherHost(gateway), blobServerPort);
    -			final List<PermanentBlobKey> keys;
    -			try {
    -				keys = BlobClient.uploadFiles(address, configuration, jobGraph.getJobID(), jobGraph.getUserJars());
    +			try (BlobClient blobClient = new BlobClient(address, configuration)) {
    +				ClientUtils.uploadAndSetUserJars(jobGraph, blobClient);
    --- End diff --
    
    we _could_ use `uploadJobGraphFiles` here, but there isn't really a use-case for uploading distributed cache artifacts when going through the JarRunHandler, since we're already on the server here.


---