flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9599) Implement generic mechanism to receive files via rest
Date Tue, 19 Jun 2018 20:11:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517485#comment-16517485
] 

ASF GitHub Bot commented on FLINK-9599:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6178#discussion_r196554025
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java
---
    @@ -103,77 +104,74 @@ protected void respondAsLeader(ChannelHandlerContext ctx, RoutedRequest
routedRe
     				return;
     			}
     
    -			ByteBuf msgContent = ((FullHttpRequest) httpRequest).content();
    +			final ByteBuf msgContent;
    +			Optional<byte[]> multipartJsonPayload = FileUploadHandler.getMultipartJsonPayload(ctx);
    +			if (multipartJsonPayload.isPresent()) {
    +				msgContent = Unpooled.wrappedBuffer(multipartJsonPayload.get());
    --- End diff --
    
    Let's send the Json payload as a proper `HttpRequest`, then we don't have this special
casing here.


> Implement generic mechanism to receive files via rest
> -----------------------------------------------------
>
>                 Key: FLINK-9599
>                 URL: https://issues.apache.org/jira/browse/FLINK-9599
>             Project: Flink
>          Issue Type: New Feature
>          Components: REST
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.6.0
>
>
> As a prerequisite for a cleaner implementation of FLINK-9280 we should
>  * extend the RestClient to allow the upload of Files
>  * extend FileUploadHandler to accept mixed multi-part requests (json + files)
>  * generalize mechanism for accessing uploaded files in {{AbstractHandler}}
> Uploaded files can be forwarded to subsequent handlers as an attribute, similar to the
existing special case for the {{JarUploadHandler}}. The JSON body can be forwarded by replacing
the incoming http requests with a simple {{DefaultFullHttpRequest}}.
> Uploaded files will be retrievable through the {{HandlerRequest}}.
> I'm not certain if/how we can document that a handler accepts files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message