flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9563) Migrate integration tests for CEP
Date Mon, 25 Jun 2018 08:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522010#comment-16522010
] 

ASF GitHub Bot commented on FLINK-9563:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6170#discussion_r197716928
  
    --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java
---
    @@ -512,12 +491,16 @@ public String select(Map<String, List<Event>> pattern)
{
     			}
     		);
     
    -		result.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
    +		List<Either<String, String>> resultList = new ArrayList<>();
    +
    +		DataStreamUtils.collect(result).forEachRemaining(resultList::add);
     
    -		// the expected sequences of matching event ids
    -		expected = "Left(1.0)\nLeft(2.0)\nLeft(2.0)\nRight(2.0,2.0,2.0)";
    +		resultList.sort(Comparator.comparing(either -> either.toString()));
     
    -		env.execute();
    +		List<Either<String, String>> expected = Arrays.asList(Either.Left.of("1.0"),
Either.Left.of("2.0"),
    +												Either.Left.of("2.0"), Either.Right.of("2.0,2.0,2.0"));
    --- End diff --
    
    indentation should only be 1 tab


> Migrate integration tests for CEP
> ---------------------------------
>
>                 Key: FLINK-9563
>                 URL: https://issues.apache.org/jira/browse/FLINK-9563
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Deepak Sharma
>            Assignee: Deepak Sharma
>            Priority: Minor
>              Labels: pull-request-available
>
> Covers all integration tests under
> apache-flink/flink-libraries/flink-cep/src/test/java/org/apache/flink/cep



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message