flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9398) Flink CLI list running job returns all jobs except in CREATE state
Date Mon, 04 Jun 2018 10:50:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500039#comment-16500039
] 

ASF GitHub Bot commented on FLINK-9398:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6049#discussion_r192696608
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -436,15 +440,19 @@ protected void list(String[] args) throws Exception {
     
     		final List<JobStatusMessage> runningJobs = new ArrayList<>();
     		final List<JobStatusMessage> scheduledJobs = new ArrayList<>();
    +		final List<JobStatusMessage> remainingJobs = new ArrayList<>();
     		jobDetails.forEach(details -> {
     			if (details.getJobState() == JobStatus.CREATED) {
     				scheduledJobs.add(details);
    -			} else {
    +			} else if (details.getJobState() == JobStatus.RUNNING
    --- End diff --
    
    use `JobStatus#isGloballyTerminalState` instead. This covers all cases where a job can
still be considered running.


> Flink CLI list running job returns all jobs except in CREATE state
> ------------------------------------------------------------------
>
>                 Key: FLINK-9398
>                 URL: https://issues.apache.org/jira/browse/FLINK-9398
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> See: https://github.com/apache/flink/blob/4922ced71a307a26b9f5070b41f72fd5d93b0ac8/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L437-L445
> Seems like CLI command: *flink list -r* returns all jobs except jobs in *CREATE* state.
which conflicts with the CLI description: *Running/Restarting Jobs*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message