flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9257) End-to-end tests prints "All tests PASS" even if individual test-script returns non-zero exit code
Date Wed, 13 Jun 2018 13:00:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511094#comment-16511094
] 

ASF GitHub Bot commented on FLINK-9257:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6053#discussion_r195060959
  
    --- Diff: flink-end-to-end-tests/run-nightly-tests.sh ---
    @@ -30,168 +30,57 @@ if [ -z "$FLINK_DIR" ] ; then
         exit 1
     fi
     
    -source "$(dirname "$0")"/test-scripts/common.sh
    +source "$(dirname "$0")"/test-scripts/test-runner-common.sh
    --- End diff --
    
    use `END_TO_END_DIR` instead


> End-to-end tests prints "All tests PASS" even if individual test-script returns non-zero
exit code
> --------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-9257
>                 URL: https://issues.apache.org/jira/browse/FLINK-9257
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Florian Schmidt
>            Assignee: Florian Schmidt
>            Priority: Critical
>             Fix For: 1.6.0
>
>
> In some cases the test-suite exits with non-zero exit code but still prints "All tests
PASS" to stdout. This happens because how the test runner works, which is roughly as follows
>  # Either run-nightly-tests.sh or run-precommit-tests.sh executes a suite of tests consisting
of one multiple bash scripts.
>  # As soon as one of those bash scripts exists with non-zero exit code, the tests won't
continue to run and the test-suite will also exit with non-zero exit code.
>  # *During the cleanup hook (trap cleanup EXIT in common.sh) it will be checked whether
there are non-empty out files or log files with certain exceptions. If a tests fails with
non-zero exit code, but does not have any exceptions or .out files, this will still print
"All tests PASS" to stdout, even though they don't*
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message