flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks
Date Tue, 26 Jun 2018 17:20:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523995#comment-16523995
] 

ASF GitHub Bot commented on FLINK-8866:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6201#discussion_r198135589
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactory.scala
---
    @@ -16,21 +16,18 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.sources
    +package org.apache.flink.table.connector
     
     import java.util
     
    -/**
    -  * A factory to create a [[TableSource]]. This factory is used with Java's Service Provider
    -  * Interfaces (SPI) for discovering. A factory is called with a set of normalized properties
that
    -  * describe the desired table source. The factory allows for matching to the given set
of
    -  * properties and creating a configured [[TableSource]] accordingly.
    -  *
    -  * Classes that implement this interface need to be added to the
    -  * "META_INF/services/org.apache.flink.table.sources.TableSourceFactory' file of a JAR
file in
    -  * the current classpath to be found.
    -  */
    -trait TableSourceFactory[T] {
    +trait TableConnectorFactory[T] {
    --- End diff --
    
    Actually, we could also simplify this and call it `TableFactory`. What do you think? We
also call `CREATE TABLE` not `CREATE TABLE CONNECTOR` in SQL.


> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
>                 Key: FLINK-8866
>                 URL: https://issues.apache.org/jira/browse/FLINK-8866
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Shuyi Chen
>            Priority: Major
>              Labels: pull-request-available
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure and instantiate
TableSinks. Among other applications, this is necessary in order to declare table sinks in
an environment file of the SQL client. Such that the sink can be used for {{INSERT INTO}}
statements.
> Below are a few major changes in mind. 
> 1) Add TableSinkFactory/TableSinkFactoryService similar to TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both) for both TableSource
and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to identify whether
it's source or sink.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message