flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8863) Add user-defined function support in SQL Client
Date Mon, 11 Jun 2018 16:23:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508306#comment-16508306
] 

ASF GitHub Bot commented on FLINK-8863:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6090#discussion_r194458815
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/FunctionDescriptor.scala
---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.descriptors
    +
    +/**
    +  * Function Descriptor
    +  */
    +class FunctionDescriptor(var name: String) extends Descriptor {
    --- End diff --
    
    As mentioned before, we should document every method and have more fluent method names.
    
    E.g.
    ```
    Function.using(...)
    ```
    
    I know `Function` is pretty generic but we do the same with `Kafka`, `Filesystem` etc.


> Add user-defined function support in SQL Client
> -----------------------------------------------
>
>                 Key: FLINK-8863
>                 URL: https://issues.apache.org/jira/browse/FLINK-8863
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>            Priority: Major
>
> This issue is a subtask of part two "Full Embedded SQL Client" of the implementation
plan mentioned in [FLIP-24|https://cwiki.apache.org/confluence/display/FLINK/FLIP-24+-+SQL+Client].

> It should be possible to declare user-defined functions in the SQL client. For now, we
limit the registration to classes that implement {{ScalarFunction}}, {{TableFunction}}, {{AggregateFunction}}.
Functions that are implemented in SQL are not part of this issue. 
> I would suggest to introduce a {{functions}} top-level property. The declaration could
look similar to: 
> {code} 
> functions: 
>   - name: testFunction 
>     from: class <-- optional, default: class 
>     class: org.my.MyScalarFunction 
>     constructor: <-- optional, needed for certain types of functions 
>       - 42.0 
>       - class: org.my.Class <-- possibility to create objects via properties 
>         constructor: 
>           - 1 
>           - true 
>           - false 
>           - "whatever" 
>           - type: INT 
>             value: 1 
> {code} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message