flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause
Date Thu, 28 Jun 2018 17:36:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526597#comment-16526597
] 

ASF GitHub Bot commented on FLINK-8650:
---------------------------------------

GitHub user snuyanzin opened a pull request:

    https://github.com/apache/flink/pull/6226

    [FLINK-8650] Tests for WINDOW clause and documentation update

    *Thank you very much for contributing to Apache Flink - we are happy that you want to
help us improve Flink. To help the community review your contribution in the best possible
way, please go through the checklist below, which will get the contribution into a shape in
which it can be best reviewed.*
    
    *Please understand that we do not do this to make contributions to Flink a hassle. In
order to uphold a high standard of quality for code contributions, while at the same time
managing a large number of contributions, we need contributors to prepare the contributions
well, and give reviewers enough contextual information for the review. Please also understand
that contributions that do not follow this guide will take longer to review and thus typically
be picked up with lower priority by the community.*
    
    ## Contribution Checklist
    
      - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
      
      - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request",
where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you
are unsure about which is the best component.
      Typo fixes that have no associated JIRA issue should be named following this pattern:
`[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc
for PuncuatedWatermarkGenerator`.
    
      - Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
      
      - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
    
      - Each pull request should address only one issue, not mix up code from multiple issues.
      
      - Each commit in the pull request has a meaningful commit message (including the JIRA
id)
    
      - Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
    
    
    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    test and documentation coverage of WINDOW clause
    
    
    ## Brief change log
    
      - *Test that the same queries but with different specification of windows have the same
plan*
      - *Mentioning in doc WINDOW syntax* 
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    via running of org.apache.flink.table.api.stream.sql.OverWindowTest
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/snuyanzin/flink FLINK_8560

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6226
    
----
commit 85451a2f9e6d1cd5d8b98fa2bba5c92326e817ce
Author: snuyanzin <snuyanzin@...>
Date:   2018-06-28T16:19:25Z

    [FLINK-8650] Tests for WINDOW clause and documentation update

----


> Add tests and documentation for WINDOW clause
> ---------------------------------------------
>
>                 Key: FLINK-8650
>                 URL: https://issues.apache.org/jira/browse/FLINK-8650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>
> We support queries with a {{WINDOW}} clause like:
> {code}
> SELECT a, SUM(c) OVER w, MIN(c) OVER w FROM MyTable WINDOW w AS (PARTITION BY a ORDER
BY proctime ROWS BETWEEN 4 PRECEDING AND CURRENT ROW)
> {code}
> But this is neither documented nor tested.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message