flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8468) Make the connector to take advantage of AMQP features (routing key, exchange and message properties)
Date Fri, 08 Jun 2018 16:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506204#comment-16506204
] 

ASF GitHub Bot commented on FLINK-8468:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r194109518
  
    --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
    @@ -105,7 +153,18 @@ public void invoke(IN value) {
     		try {
     			byte[] msg = schema.serialize(value);
     
    -			channel.basicPublish("", queueName, null, msg);
    +			if (messageCompute == null) {
    +				channel.basicPublish("", queueName, null, msg);
    +			} else {
    +				String rk = messageCompute.computeRoutingKey(value);
    +				String exchange = messageCompute.computeExchange(value);
    +				channel.basicPublish((exchange != null) ? exchange : "",
    --- End diff --
    
    ping


> Make the connector to take advantage of AMQP features (routing key, exchange and message
properties)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8468
>                 URL: https://issues.apache.org/jira/browse/FLINK-8468
>             Project: Flink
>          Issue Type: Improvement
>          Components: RabbitMQ Connector
>    Affects Versions: 1.4.0
>            Reporter: Ph.Duveau
>            Priority: Major
>
> Make the connector to take advantage of AMQP features by adding a constructor and an
interface to implement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message